Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up oci-prow-worker on OCI with OpenTofu #68

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Set up oci-prow-worker on OCI with OpenTofu #68

wants to merge 11 commits into from

Conversation

embik
Copy link
Member

@embik embik commented Apr 14, 2024

This is a WIP PR for creating a OKE cluster via OpenTofu that we can use as a new prow worker cluster.

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Apr 14, 2024
@kcp-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 14, 2024
@embik
Use oracle/oci provider
2401e5e 
Signed-off-by: Marvin Beckers <[email protected]>
@embik
Add some networking primitives
3b7a5cf 
Signed-off-by: Marvin Beckers <[email protected]>
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2024
embik added 2 commits May 7, 2024 13:02
@embik
Produce working tofu plan output
d90df40 
Signed-off-by: Marvin Beckers <[email protected]>
@embik
Add state backend in OCI bucket
12dd4f8 
Signed-off-by: Marvin Beckers <[email protected]>
mjudeikis
mjudeikis reviewed Jun 7, 2024
View reviewed changes
iac/oci-prow-worker/README.md

The following environment variables are required before running any `make` targets:

- `AWS_ACCESS_KEY_ID`: Needs to be the key ID for a [Customer Secret Key](https://docs.oracle.com/en-us/iaas/Content/Identity/Tasks/managingcredentials.htm#Working2) to access OCI's S3-compatible storage buckets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add .env.example file and source it in the make file? And ignore .env in git too. Basically placeholder for env to be used when using locally?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var.node_pool_ssh_public_key is missing too. Do we have shared on?

@mjudeikis
Copy link
Contributor

/lgtm
/approve
/hold

@kcp-ci-bot kcp-ci-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jun 7, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d3363b8ec4349c6eefd20a27c6d9ee8ead41081

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mjudeikis
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
@kcp-ci-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@embik
Run tofu fmt
906f640 
Signed-off-by: Marvin Beckers <[email protected]>
@embik
Update provider oci to version 6.2.0
f77e72b 
Signed-off-by: Marvin Beckers <[email protected]>
@embik
Add .env.example file
65ea17d 
Signed-off-by: Marvin Beckers <[email protected]>
@embik
Migrate cluster to use VCN native mode
755efb4 
Signed-off-by: Marvin Beckers <[email protected]>
@embik embik mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjudeikis mjudeikis Awaiting requested review from mjudeikis

Assignees

@mjudeikis mjudeikis

Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@embik @kcp-ci-bot @mjudeikis