Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 switch to logicalcluster.v3 #20

Merged
merged 6 commits into from
Dec 15, 2022
Merged

🌱 switch to logicalcluster.v3 #20

merged 6 commits into from
Dec 15, 2022

Conversation

p0lyn0mial
Copy link
Contributor

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2022
@p0lyn0mial p0lyn0mial force-pushed the logicalcluster-v3 branch 3 times, most recently from 8505cf4 to 5c8484d Compare December 9, 2022 12:59
@p0lyn0mial p0lyn0mial mentioned this pull request Dec 14, 2022
Merged
@p0lyn0mial p0lyn0mial changed the title WIP: logicalcluster v3 🌱 WIP: logicalcluster v3 Dec 15, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2022
@p0lyn0mial p0lyn0mial changed the title 🌱 WIP: logicalcluster v3 🌱 switch to logicalcluster.v3 Dec 15, 2022
@p0lyn0mial
Copy link
Contributor Author

do we want to create v2 for this pkg?

@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Dec 15, 2022 •
edited
Loading

do we want to create v2 for this pkg?

mhm, it looks like first we would have to fix the dependency cycle between code-generator (https://github.com/kcp-dev/code-generator/blob/17d4a705cf1535f7864974b7c806f3e56148d6ed/pkg/internal/clientgen/fake_group.go#L58) and client-go, see kcp-dev/code-generator#75 for more info

we cannot introduce v2 because we need a change in code-generator to import github.com/kcp-dev/client-go/v2/ in the generated code and then use it to regenerate client-go.

@p0lyn0mial
Copy link
Contributor Author

/assign @sttts

@sttts
Copy link
Member

sttts commented Dec 15, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@openshift-merge-robot openshift-merge-robot merged commit c1e5154 into kcp-dev:main Dec 15, 2022
@MikeSpreitzer MikeSpreitzer mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfestal davidfestal Awaiting requested review from davidfestal

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0lyn0mial @sttts @openshift-merge-robot