Construct: support exception key top-level and in assertions
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well, that might be a problem. I can tell you that this PR is useless in the current state, because the files generated by KSC for the |
|
It would be easier to test if CI could run these tests and show which exceptions would actually thrown. Feel free to edit this PR and use actual exceptions. |
List of tests that depends on `asserts[i].exception` key: expr_to_i_trailing `exception` key: default_endian_expr_exception eof_exception_bytes eof_exception_sized eof_exception_u4 eos_exception_bytes eos_exception_sized eos_exception_u4 valid_fail_anyof_int valid_fail_contents valid_fail_eq_bytes valid_fail_eq_int valid_fail_eq_str valid_fail_expr valid_fail_inst valid_fail_max_int valid_fail_min_int valid_fail_range_bytes valid_fail_range_float valid_fail_range_int valid_fail_range_str
Mingun
force-pushed
the
construct-kst-fixes
branch
from
3a9eaef
to
ba05e7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result, a bunch of tests was generated that checks exceptions. I checked in the code, that Construct does not wrap exceptions in its own exception classes. I didn't check that new tests work