Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submodules: runtime for Rust, Java Viewer and update all outdated submodules #1098

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mingun
Copy link

@Mingun Mingun commented Mar 29, 2024

This PR adds missing submodule for Rust and also a submodule of a graphical viewer, so newcomers will be aware of it. It also updates all outdated submodules because why not?

@generalmimon
Copy link
Member

I'm not sure adding Rust and C runtimes is the right thing to do, because it's kind of false advertising - it leads people to believe that Rust and C are supported languages when they're not (if they're not even in the CI dashboard, they can hardly be considered supported).

For this reason, I'm also not very happy that rust is listed in KSC's --help when it's nowhere near production ready:

$ kaitai-struct-compiler --help
kaitai-struct-compiler 0.11-SNAPSHOT20240330.121109.29f7a592
Usage: kaitai-struct-compiler [options] <file>...

  <file>...                source files (.ksy)
  -t, --target <language>  target languages (graphviz, all, perl, java, go, cpp_stl, php, lua, html, ruby, construct, javascript, csharp, rust, python, nim)

... because I've seen in the past that this alone has confused a number of people.

@Mingun
Copy link
Author

Mingun commented Apr 1, 2024

But I want to make Rust ready to be production only and I want to track the results in dashboard! Agreed with C -- I was under impression, that this runtime is ready, but it is just placeholder. That commit can be removed. Anyway, the goal is to have all runtimes to which we have compilers, no matter how mature of them.

I also want to have Rust in dashboard to check progress, but not figured yet how to add it.

@Mingun
Copy link
Author

Mingun commented Apr 5, 2024

@generalmimon, I removed C runtime from PR and update all submodules to the latest versions at time of writing.

@Mingun Mingun changed the title Add submodules: runtime for Rust and C, Java Viewer and update all outdated submodules Add submodules: runtime for Rust, Java Viewer and update all outdated submodules Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants