Fix setup.py reading setup.cfg manually #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading setup.cfg manually is not supported by setuptools and causes errors with some setup.cfg features (see pypa/setuptools#1869). The supported way to use setup.cfg is to call setup() with no arguments and let setuptools read and parse setup.cfg itself.
KOLANICH
approved these changes
Jun 30, 2020
|
BTW, yet another transition will be needed in future: https://www.python.org/dev/peps/pep-0621/ |
generalmimon
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
@dgelessus LGTM, thanks for the fix!
You probably should also add
pyproject.toml
I have no idea if it will help anything, but sure, feel free to open a new PR for that. I'll just merge this as it is, let's keep the PRs small and easy to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20.
Reading setup.cfg manually is not supported by setuptools and causes errors with some setup.cfg features (see pypa/setuptools#1869). The supported way to use setup.cfg is to call
setup()with no arguments and let setuptools read and parse setup.cfg itself.