[OpenShift] Remove ca_certs, deprecate validate_cert, fix unreleased regression #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/openshift-fix-ca-certs
branch
from
ffc17bb
to
6c8c58c
Compare
consideRatio
changed the title
consideRatio
force-pushed
the
pr/openshift-fix-ca-certs
branch
from
6c8c58c
to
4bfb274
Compare
This was referenced Jul 4, 2023
consideRatio
force-pushed
the
pr/openshift-fix-ca-certs
branch
from
4bfb274
to
b0367d7
Compare
manics
reviewed
Jul 5, 2023
Co-authored-by: Simon Li <[email protected]>
|
@manics thank you for reviewing!!!!! |
|
Applied code suggestions and rebased #641 on top of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #637. This PR includes only the last commit 4bfb274.