Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a release module for the tck distribution #1531

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Copy link
Contributor

@gurunrao gurunrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @starksm64. LGTM.

el-tck/pom.xml Outdated Show resolved Hide resolved
…nguage-tck version change

Signed-off-by: Scott M Stark <[email protected]>
</goals>
<configuration>
<groupId>jakarta.tck</groupId>
<artifactId>el-tck</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed to "el-platform-tck" or rename el module artifact id to "el-tck"

Copy link
Contributor

@alwin-joseph alwin-joseph Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to have a common naming convention for all modules in platform TCK. Maybe better to keep "el-tck" and rename the artifact id in module el. I named it "el-platform-tck" to distinguish with the standalone el-tck/ folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alwin-joseph - Please note rename of EL standalone TCK, should not duplicate balloted EL standalone TCK artifact.That will impact future service releases of EL standalone TCK.

Copy link
Contributor

@alwin-joseph alwin-joseph Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For standalone el-tck/ module, we have below :

<artifactId>jakarta-expression-language-tck</artifactId>
<name>el-tck</name>

For platform el/ module

<artifactId>el-platform-tck</artifactId>
<name>el</name>

Maybe we can continue to use el-platform-tck as artifact name for platform(so as to not confuse with el-tck module name of the standalone) and correct the same here in line 128, for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to start a distribution module
3 participants