dvclive: update log_artifact options #4690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link Check ReportThere were no links to check! |
daavoo
reviewed
Jul 11, 2023
| @@ -68,6 +71,11 @@ all the metadata passed as arguments to the corresponding `dvc.yaml`. Passing | |||
| artifact. Useful if you don't want to track the original path in your repo | |||
| (for example, it is outside the repo or in a Git-ignored directory). | |||
|
|
|||
| - `cache` - <abbr>cache</abbr> the files with DVC to | |||
| [track](/doc/dvclive/how-it-works#track-large-artifacts-with-dvc) them outside | |||
| of Git. Defaults to `True`, but set to `False` if you want to annotate | |||
There was a problem hiding this comment.
Minor and might be only my opinion, but the explanation of False feels redundant
There was a problem hiding this comment.
Yeah, not that strong an opinion, but since I don't think there's an equivalent in other loggers, I think it's worth being explicit here about why you would want to use this option.
daavoo
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4686