Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice: remove inner fields access methods #564

Open
wants to merge 1 commit into
base: 01-15-blockservice_move_session_handling_as_part_of_the_interface
Choose a base branch
from

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 15, 2024

I'll do changelog once we decide on an option.

Copy link
Contributor Author

Jorropo commented Jan 15, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Jorropo and the rest of your teammates on Graphite Graphite

@Jorropo Jorropo marked this pull request as draft January 15, 2024 12:39
@Jorropo Jorropo force-pushed the 01-15-blockservice_move_session_handling_as_part_of_the_interface branch from 1da7fe3 to 04e1669 Compare January 15, 2024 12:43
@Jorropo Jorropo force-pushed the blockservice-interface-no-inner-fields branch from 8de936c to c1b8f27 Compare January 15, 2024 12:43
@Jorropo Jorropo force-pushed the 01-15-blockservice_move_session_handling_as_part_of_the_interface branch from 04e1669 to b3ef103 Compare January 15, 2024 12:44
@Jorropo Jorropo force-pushed the blockservice-interface-no-inner-fields branch from c1b8f27 to ff49b41 Compare January 15, 2024 12:44
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a76d47d) 65.45% compared to head (783f4ca) 65.40%.

Impacted file tree graph

@@                                          Coverage Diff                                          @@
##           01-15-blockservice_move_session_handling_as_part_of_the_interface     #564      +/-   ##
=====================================================================================================
- Coverage                                                              65.45%   65.40%   -0.06%     
=====================================================================================================
  Files                                                                    207      207              
  Lines                                                                  25606    25602       -4     
=====================================================================================================
- Hits                                                                   16760    16744      -16     
- Misses                                                                  7367     7375       +8     
- Partials                                                                1479     1483       +4     
Files Coverage Δ
gateway/blocks_backend.go 42.27% <0.00%> (-0.10%) ⬇️
blockservice/blockservice.go 75.72% <37.50%> (-1.34%) ⬇️

... and 14 files with indirect coverage changes

@Jorropo Jorropo force-pushed the 01-15-blockservice_move_session_handling_as_part_of_the_interface branch from b3ef103 to 89e9bce Compare January 15, 2024 12:46
@Jorropo Jorropo force-pushed the blockservice-interface-no-inner-fields branch from ff49b41 to e51c82f Compare January 15, 2024 12:46
@Jorropo Jorropo force-pushed the 01-15-blockservice_move_session_handling_as_part_of_the_interface branch from 89e9bce to 739e5e8 Compare January 15, 2024 12:57
@Jorropo Jorropo force-pushed the blockservice-interface-no-inner-fields branch from e51c82f to 55dc0c2 Compare January 15, 2024 12:57
We shouldn't expose inner implementation details of the blockservice to consumers.

For example by using the blockstore for the .Has call, the gateway skipped verifcid and blocker checks. Probably fine but not we want to do.
@Jorropo Jorropo force-pushed the 01-15-blockservice_move_session_handling_as_part_of_the_interface branch from 739e5e8 to a76d47d Compare January 15, 2024 17:30
@Jorropo Jorropo force-pushed the blockservice-interface-no-inner-fields branch from 55dc0c2 to 783f4ca Compare January 15, 2024 17:30
@Jorropo Jorropo marked this pull request as ready for review January 16, 2024 09:10
@hacdias hacdias removed their request for review May 27, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant