Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored the lv2vFormat method to consider long messages #85

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Refactored the lv2vFormat method to consider long messages #85

wants to merge 2 commits into from

Conversation

mischareitsma
Copy link
Contributor

@mischareitsma mischareitsma commented May 9, 2019 •
edited
Loading

Closes #66

@mischareitsma
Copy link
Contributor Author

@atiplea There is still a bit of a mismatch between the use of ordinary strings and Buffers. Might be worth tackling another time when we also have some sort of integration tests. I don't want to change too much in one go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow messages with length > 2^16-2
1 participant
@mischareitsma