Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make references to websql using module id instead of by path #282

Closed
wants to merge 1 commit into from

Conversation

erikvold
Copy link
Contributor

No description provided.

@brettz9
Copy link
Collaborator

brettz9 commented Feb 13, 2017

Aha... Good find, thanks! Aim to get to this shortly...

@erikvold
Copy link
Contributor Author

Hmm actually I think I was mistaken, this patch doesn't seem to resolve the error I was getting in #259 (comment)

@brettz9
Copy link
Collaborator

brettz9 commented Feb 16, 2017

I did incorporate your change, but I think I might have added the relative path myself due to this approach not working either. :) I would think your approach would work as it is a dependency of thisone...Anyways closing this but if you find another fix, feel free to make a new PR or overwrite this one.

@brettz9 brettz9 closed this Feb 16, 2017
@brettz9
Copy link
Collaborator

brettz9 commented Feb 23, 2017

Should truly be fixed now in master (as discussed in #262).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants