[Tests] Fixed breaking changes introduced by twig/twig v3.11.0 #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
fix-twig-deprecation-msg-change
branch
from
ff17519
to
0d135d3
Compare
konradoboza
approved these changes
Aug 9, 2024
Steveb-p
requested changes
Aug 9, 2024
...lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/functions/ez_file_size/ez_file_size.test
Show resolved
Hide resolved
alongosz
force-pushed
the
fix-twig-deprecation-msg-change
branch
from
0d135d3
to
095faa4
Compare
|
Steveb-p
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
The latest Twig release (
twig/twig:v3.11.0) changed deprecation message format. As we deprecated our own filters and functions, it crashed our Twig integration tests.Moreover I see some sort of template caching has been introduced, making deprecation being thrown only once, per 1st template loading. I had to remove other snippets from a template file as they didn't produce any message. While overall more caching is better, I think Twig's integration test shouldn't behave this way. There's nothing I can do about it right now.
Update: The removed test cases are also covered fully by the test cases testing the actual filters and functions (not their deprecated counterparts). E.g: https://github.com/ibexa/core/blob/e766878c07435ee29997e9d4e704fd8235c9cce6/tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/filters/ibexa_data_attributes_serialize.test