Links BeforeEvent & AfterEvent to SF's Event #377
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this is outside the actual PHP API Ref Ibexa\Contracts scope, this isn't documented. This @link can help by linking to SF repo.
adriendupuis
changed the title
adriendupuis
changed the title
|
alongosz
reviewed
Jun 10, 2024
There was a problem hiding this comment.
@adriendupuis I've released code style 1.2.1. You can rebase this one against the latest 4.6 changes to also have unrelated PHPStan issues fixed.
adamwojs
approved these changes
Jun 10, 2024
|
@adriendupuis Could you please address issues reported by CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is outside the actual PHP API Ref
Ibexa\Contractsscope,Symfony\Contracts\EventDispatcher\Eventisn't documented. Those@linktags can help.Renders as follow:
For comparison: https://doc.ibexa.co/en/master/api/php_api/php_api_reference/classes/Ibexa-Contracts-Core-Repository-Event-BeforeEvent.html
Description:
For QA:
Documentation: