Remove loading docker config inside dev container #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@munapower This should resolve Issue #715! Can you please test it. Will keep this as draft for now. |
munapower
requested changes
Oct 24, 2023
With recent versions of Docker Desktop (and others Rancher Desktop), the docker configuration loaded into the dev container can not resolve the path to the docker socket. We let users the option to mount the docker configuration inside the container if needed. Signed-off-by: Marcus Brandenburger <[email protected]>
Signed-off-by: Marcus Brandenburger <[email protected]>
mbrandenburger
force-pushed
the
docker-config
branch
from
f4adee0
to
37aac56
Compare
munapower
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent versions of Docker Desktop (and others Rancher Desktop), the docker configuration loaded into the dev container can not resolve the path to the docker socket. We let users the option to mount the docker configuration inside the container if needed.
This PR fixes #715