Upgrade yq from v3.x to v4.x #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some example scripts still use an older version of yq. To run the example scripts properly newer version of yq is added. Signed-off-by: Deepjyoti-Sarmah <[email protected]>
utils/docker/base-dev/Dockerfile
Outdated
| @@ -86,7 +86,7 @@ RUN go install golang.org/x/tools/cmd/goimports@latest \ | |||
| && go install github.com/maxbrunsfeld/counterfeiter/v6@latest \ | |||
| && go install honnef.co/go/tools/cmd/[email protected] \ | |||
| && go install github.com/client9/misspell/cmd/misspell@latest \ | |||
| && go install github.com/mikefarah/yq/v3@latest | |||
| && go get github.com/mikefarah/yq/v4@latest | |||
There was a problem hiding this comment.
I believe this should be go install ...
There was a problem hiding this comment.
I thank you pointing out the error and fixing it.
…thub.com/mikefarah/yq/v4@latest" Signed-off-by: Deepjyoti-Sarmah <[email protected]>
Signed-off-by: Deepjyoti-Sarmah <[email protected]>
|
@chenchanglew may I ask you to look at this PR as well and test fpc samples? |
|
ya sure let me check it. |
There was a problem hiding this comment.
Thanks @Deepjyoti-Sarmah for this PR! I tested it almost worked. Here some changes.
samples/deployment/fabric-smart-client/the-simple-testing-network/env.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: Deepjyoti-Sarmah <[email protected]>
Signed-off-by: Deepjyoti-Sarmah <[email protected]>
|
Hey @mbrandenburger thank you for the suggestion. I have made the required changes |
Signed-off-by: Marcus Brandenburger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some example scripts still use an older version of yq. To run the example scripts properly newer version of yq is added.
What this PR does / why we need it: Upgrades the yq V3.x to yq v4.x
Which issue(s) this PR fixes:
./samples/deployment/test-network/setup.sh./samples/deployment/fabric-smart-client/the-simple-testing-network/env.sh./samples/deployment/test-network/update-connection.sh./samples/deployment/test-network/fabric-samples/test-network-nano-bash/README.md./README.md./utils/docker/dev_peer_cc-builder/Dockerfile./utils/docker/base-dev/DockerfileFixes #719