This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Feature/simple rules #470

Draft

etschelp wants to merge 20 commits into hyperledger-labs:main from boschresearch:feature/simple-rules

Contributor

etschelp commented Jun 11, 2021 •

edited by gitpod-io bot

Loading

https://hackmd.io/2m16i56sTtmYi9tVuklVVw?view

etschelp added 3 commits

June 11, 2021 16:51


          POC to check how difficult it is to plug rules with some logic into t…

c5b146f

…he aca-py event handler

Signed-off-by: Philipp Etschel <[email protected]>


          license fix

60f15b4

Signed-off-by: Philipp Etschel <[email protected]>


          Merge branch 'master' into feature/simple-rules

602bdf2

etschelp marked this pull request as draft

June 11, 2021 15:28

etschelp added 6 commits

June 14, 2021 15:56


          allow multiple tasks per id.

3cda8ca

Signed-off-by: Philipp Etschel <[email protected]>


          renamed classes

9ed4100

Signed-off-by: Philipp Etschel <[email protected]>


          simplified again, rules run once or multiple times and are not linked…

… to a partner

Signed-off-by: Philipp Etschel <[email protected]>


          more deletions

14e8834

Signed-off-by: Philipp Etschel <[email protected]>


          does not matter right now

6b485bf

Signed-off-by: Philipp Etschel <[email protected]>


          formatter and header

e0a3bdd

Signed-off-by: Philipp Etschel <[email protected]>

domwoe mentioned this pull request

As a user of the BPA I want that certain requests are accepted automatically #375

Open

etschelp added 9 commits

June 17, 2021 12:59


          rules without rule book impl

6591a84

Signed-off-by: Philipp Etschel <[email protected]>


          added rest controller and crud methods

337c8b8

Signed-off-by: Philipp Etschel <[email protected]>


          cleaning up

03df182

Signed-off-by: Philipp Etschel <[email protected]>


          pmd and apply check

9e59b53

Signed-off-by: Philipp Etschel <[email protected]>


          Merge branch 'master' into feature/simple-rules

60e00ce


          removed rulebook dependency

329901e

Signed-off-by: Philipp Etschel <[email protected]>


          Merge branch 'master' of https://github.com/hyperledger-labs/business…

8e4229c

…-partner-agent into feature/simple-rules

Signed-off-by: Philipp Etschel <[email protected]>

# Conflicts:
#	backend/README.md
#	backend/pom.xml


          Merge branch 'master' into feature/simple-rules

d7b5397


          renamed migration

00bcf3a

Signed-off-by: Philipp Etschel <[email protected]>

l-wegner reviewed

View reviewed changes

Contributor

l-wegner left a comment

I made some minor suggestions.

...iness-partner-agent/src/main/java/org/hyperledger/bpa/controller/AriesWebhookController.java Outdated

+                  @Inject
+                  @Named("rules")
+                  EventHandler rulesEventHandler;
                   @Post(WEBHOOK_CONTROLLER_PATH + "/{eventType}")
                   public void logEvent(

Contributor

l-wegner Jul 15, 2021

rename method? It does not solely log.
accept event? consume?

backend/business-partner-agent/src/main/java/org/hyperledger/bpa/impl/rules/RulesData.java

+                      abstract boolean apply(EventContext ctx);
+                      @SuppressWarnings("unused")
+                      private String type;

Contributor

l-wegner Jul 15, 2021

What is the purpose of this field? It's not used via accessors and builders. The database stores Triggers as jsonb.

How about pulling this field into the subclasses, if there is a purpose for it. And then change Trigger to an interface, which is the also a functional one. Or does that create serialization issues?

backend/business-partner-agent/src/main/java/org/hyperledger/bpa/impl/rules/RulesData.java

+                      abstract void run(EventContext ctx);
+                      @SuppressWarnings("unused")
+                      private String type;

Contributor

l-wegner Jul 15, 2021

Same as Trigger.type?

backend/business-partner-agent/src/main/java/org/hyperledger/bpa/impl/rules/RulesData.java

+                          @Override
+                          public boolean apply(EventContext ctx) {
+                              return false;

Contributor

l-wegner Jul 15, 2021

maybe add a TODO, that this can be implemented as soon as proof templates are available?

backend/business-partner-agent/src/main/java/org/hyperledger/bpa/impl/rules/RulesData.java

+                      public static final String CONNECTION_TRIGGER_NAME = "connection";
+                      public static final String PROOF_RECEIVED_TRIGGER_NAME = "proof_received";
+                      abstract boolean apply(EventContext ctx);

Contributor

l-wegner Jul 15, 2021

Apply is a very generic name.
shallApplyAction
applicableRule

backend/business-partner-agent/src/main/java/org/hyperledger/bpa/impl/rules/RulesData.java

+                          @Override
+                          public boolean apply(EventContext ctx) {
+                              ConnectionRecord connRec = ctx.getConnRec();
+                              boolean apply = connRec != null && ConnectionState.REQUEST.equals(connRec.getState());

Contributor

l-wegner Jul 15, 2021

boolean isRequest = connRec != null && ConnectionState.REQUEST.equals(connRec.getState());
boolean roleMatches = role==null || connRec != null && role.equals(connRec.getTheirRole());
return isRequest && roleMatches;

backend/business-partner-agent/src/main/java/org/hyperledger/bpa/impl/rules/RulesData.java

+                              ConnectionRecord connRec = ctx.getConnRec();
+                              boolean apply = connRec != null && ConnectionState.REQUEST.equals(connRec.getState());
+                              if (role != null) {
+                                  apply = apply && role.equals(connRec.getTheirRole());

Contributor

l-wegner Jul 15, 2021

connRec could be null?

backend/business-partner-agent/src/main/java/org/hyperledger/bpa/impl/rules/RulesData.java

+                  private Trigger trigger;
+                  private Action action;
+                  @JsonTypeInfo(

Contributor

l-wegner Jul 15, 2021

I used @JsonTypeInfo(use = JsonTypeInfo.Id.CLASS) to store the type information. Is there a decision, which one to use?

backend/business-partner-agent/src/main/java/org/hyperledger/bpa/impl/rules/RulesService.java

+                  public List<RulesData> getAll() {
+                      List<RulesData> result = new ArrayList<>();
+                      rr.findAll().forEach(active -> result.add(RulesData.fromActive(active)));

Contributor

l-wegner Jul 15, 2021

return rr.findAll().stream().map(RulesData::fromActive).collect(Collectors.toList());

backend/business-partner-agent/src/test/java/org/hyperledger/bpa/impl/rules/RunRulesTest.java

+                      Partner p = ModelBuilder.buildDefaultPartner().setConnectionId(connectionId);
+                      pr.save(p);
+                      rs.add(new RulesData.Trigger.ConnectionTrigger(), new RulesData.Action.TagConnection());

Contributor

l-wegner Jul 15, 2021

maybe put a special action for the rule to verify it's execution? There are mutltiple path, where the ruleExecution is stopped before that.

etschelp added 2 commits

August 9, 2021 17:36


          Merge branch 'master' into feature/simple-rules

d72f01c

Signed-off-by: Philipp Etschel <[email protected]>

# Conflicts:
#	backend/business-partner-agent/pom.xml
#	backend/business-partner-agent/src/main/java/org/hyperledger/bpa/controller/AriesWebhookController.java
#	backend/business-partner-agent/src/main/java/org/hyperledger/bpa/impl/aries/ConnectionManager.java


          renamed migration

2e6bcda

Signed-off-by: Philipp Etschel <[email protected]>

domwoe added the Business Rules label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels