Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

refactor: change xeipuuv/gojsonschema to santhosh-tekuri/jsonschema package #3395

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abdulbois
Copy link
Contributor

Description:

  • Change xeipuuv/gojsonschema to santhosh-tekuri/jsonschema package inside verifiable presentation
  • Refactor related unit tests

Related to #3393

@Abdulbois Abdulbois force-pushed the replace-gojsonschema-package branch 3 times, most recently from 6233891 to d493945 Compare October 7, 2022 13:57
…ackage inside verifiable presentation. Refactor related unit tests

Signed-off-by: Abdulbois <[email protected]>
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #3395 (7e6e5f7) into main (2aee6d4) will increase coverage by 0.01%.
The diff coverage is 94.00%.

@@            Coverage Diff             @@
##             main    #3395      +/-   ##
==========================================
+ Coverage   87.98%   87.99%   +0.01%     
==========================================
  Files         332      333       +1     
  Lines       46051    46093      +42     
==========================================
+ Hits        40517    40559      +42     
  Misses       4099     4099              
  Partials     1435     1435              
Impacted Files Coverage Δ
pkg/doc/didconfig/didconfig.go 95.57% <ø> (ø)
pkg/client/didconfig/didconfig.go 93.75% <93.75%> (ø)
pkg/doc/verifiable/presentation.go 87.66% <100.00%> (+0.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -49,6 +49,7 @@ require (
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/pquerna/cachecontrol v0.1.0 // indirect
github.com/rs/cors v1.7.0 // indirect
github.com/santhosh-tekuri/jsonschema v1.2.4 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is xeipuuv/gojsonschema package still referenced somewhere? I see indirect references at lines 60-62 below.

It would be good to remove all references to xeipuuv packages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baha-sk - @Abdulbois wanted to show one example of the change to gather feedback. Once there is some feedback, all instances will be changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am for this change. A couple of days ago the old package was failing bbs signature post signing when validating the json map where an embedded json struct was being wrongly resolving to an empty RDF entry. Hopefully, this package does a better job at mapping jsonld docs.

@@ -72,6 +72,7 @@ require (
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/pquerna/cachecontrol v0.1.0 // indirect
github.com/rs/cors v1.7.0 // indirect
github.com/santhosh-tekuri/jsonschema v1.2.4 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here... lines 86-88 below

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants