Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(src/utils): refactor some function signatures in src/utils #3231

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

K-tecchan
Copy link
Contributor

@K-tecchan K-tecchan commented Aug 4, 2024

The author should do the following, if applicable

src/utils/buffer.ts
changed to default argument because it seemed redundant to handle cases where a hash function was not passed as an argument.

src/utils/url.ts
changed signatures like getQueryParams

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@K-tecchan K-tecchan marked this pull request as ready for review August 4, 2024 02:31
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (c3679b8) to head (a8d6417).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3231      +/-   ##
==========================================
- Coverage   96.21%   96.20%   -0.01%     
==========================================
  Files         151      151              
  Lines       15096    15091       -5     
  Branches     2656     2672      +16     
==========================================
- Hits        14524    14519       -5     
  Misses        572      572              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant