Add acceptance tests for how provider handles request_reason
argument
#19702
+297
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
X-Goog-Request-Reason
header is for auditing purposes in GCPWriting these tests made me realise that empty string validation doesn't cover request_reason, so I opened: #19643 . The acceptance tests are written to define the current behaviour and my expectation is that the PF schema will be update in future to add validation, make those tests fail, and the tests will be updated.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11835