Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metadatagroup in object #54

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Support metadatagroup in object #54

merged 1 commit into from
Sep 13, 2024

Conversation

gyscos
Copy link
Contributor

@gyscos gyscos commented Sep 12, 2024

This changes the model to support cases where an <object> tag includes a <metadatagroup> in addition to a <mesh>.

Here's an example of this situation from the official 3mf specs.

ObjectData can no longer be an enum, and needs to be merged into its Object parent.

The result is a breaking change.

@gyscos
Copy link
Contributor Author

gyscos commented Sep 12, 2024

Fixes #53

Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request, @gyscos!

I haven't been using 3mf-rs for importing so far, and my understanding of the spec is also limited. But this looks all very reasonable, so I'm happy to merge.

@hannobraun hannobraun merged commit a99506b into hannobraun:main Sep 13, 2024
1 check passed
@gyscos
Copy link
Contributor Author

gyscos commented Sep 13, 2024

Thanks a lot! I can imagine fornjot mostly exports 3mf files (though being able to import existing geometry might still be useful!).

Any idea when you'll have time to release 0.6.0?

@hannobraun
Copy link
Owner

Thanks a lot! I can imagine fornjot mostly exports 3mf files (though being able to import existing geometry might still be useful!).

Yeah, importing geometry is going to happen at some point, but so far Fornjot is just exporting.

Any idea when you'll have time to release 0.6.0?

Hopefully next week, if nothing unexpected gets in the way. Let me know, if it's urgent for you. I can probably speed it up a little.

@gyscos
Copy link
Contributor Author

gyscos commented Sep 13, 2024

Nothing urgent - we're waiting for this in stl-thumb, but nothing's on fire :)

@hannobraun
Copy link
Owner

@gyscos
New version is released: #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants