Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error due to undefined variables #532

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jun 16, 2024

When buidling LibreSSL + picotls with -Wundef option, the build fails due to the following error.

2024-06-16T05:50:37.9131759Z In file included from /home/runner/work/ngtcp2/ngtcp2/ngtcp2-1.6.0-DEV/crypto/picotls/picotls.c:36:
2024-06-16T05:50:37.9134332Z /home/runner/work/ngtcp2/ngtcp2/picotls-libressl/include/picotls/openssl.h:91:5: error: 'PTLS_OPENSSL_HAVE_CHACHA20_POLY1305' is not defined, evaluates to 0 [-Werror,-Wundef]
2024-06-16T05:50:37.9136125Z #if PTLS_OPENSSL_HAVE_CHACHA20_POLY1305
2024-06-16T05:50:37.9136719Z     ^
2024-06-16T05:50:37.9138515Z /home/runner/work/ngtcp2/ngtcp2/picotls-libressl/include/picotls/openssl.h:108:5: error: 'PTLS_OPENSSL_HAVE_CHACHA20_POLY1305' is not defined, evaluates to 0 [-Werror,-Wundef]
2024-06-16T05:50:37.9140294Z #if PTLS_OPENSSL_HAVE_CHACHA20_POLY1305
2024-06-16T05:50:37.9141272Z     ^
2024-06-16T05:50:37.9143043Z /home/runner/work/ngtcp2/ngtcp2/picotls-libressl/include/picotls/openssl.h:119:5: error: 'PTLS_OPENSSL_HAVE_X25519' is not defined, evaluates to 0 [-Werror,-Wundef]
2024-06-16T05:50:37.9144740Z #if PTLS_OPENSSL_HAVE_X25519
2024-06-16T05:50:37.9145253Z     ^
2024-06-16T05:50:37.9147028Z /home/runner/work/ngtcp2/ngtcp2/picotls-libressl/include/picotls/openssl.h:127:5: error: 'PTLS_OPENSSL_HAVE_CHACHA20_POLY1305' is not defined, evaluates to 0 [-Werror,-Wundef]
2024-06-16T05:50:37.9148787Z #if PTLS_OPENSSL_HAVE_CHACHA20_POLY1305
2024-06-16T05:50:37.9149365Z     ^
2024-06-16T05:50:37.9221836Z 4 errors generated.
2024-06-16T05:50:37.9278275Z make[2]: *** [crypto/picotls/CMakeFiles/ngtcp2_crypto_picotls_static.dir/build.make:76: crypto/picotls/CMakeFiles/ngtcp2_crypto_picotls_static.dir/picotls.c.o] Error 1
2024-06-16T05:50:37.9280880Z make[1]: *** [CMakeFiles/Makefile2:553: crypto/picotls/CMakeFiles/ngtcp2_crypto_picotls_static.dir/all] Error 2

This patch fixes them.

@kazuho kazuho merged commit e4f0a27 into h2o:master Aug 1, 2024
10 checks passed
@kazuho
Copy link
Member

kazuho commented Aug 1, 2024

Thank you for the PR (and thank you for making adjustments due to other changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants