-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nfpm): support arm in termux #4901
Conversation
211f449
to
84147c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4901 +/- ##
==========================================
+ Coverage 83.77% 83.91% +0.14%
==========================================
Files 135 139 +4
Lines 13029 11110 -1919
==========================================
- Hits 10915 9323 -1592
+ Misses 1677 1334 -343
- Partials 437 453 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you!
@rsteube what about /etc/resolv.conf ? its not present in |
@rsteube you are completely wrong, have you test yourself in termux? also, read the termux docs, what's this? wrong https://github.com/carapace-sh/go/blob/master/termux/1-hardcoded-etc-resolv-conf/patch.diff#L59 wrong https://github.com/carapace-sh/go/blob/master/termux/1-hardcoded-etc-resolv-conf/patch.diff#L68 |
@aicynide I appreciate your participation in this, but your tone is slightly off. |
@aicynide your tone is very off in this, let's be more civil in the next interactions, please. FWIW we have a CoC: https://github.com/goreleaser/goreleaser?tab=coc-ov-file#readme |
This adds
arm
support for termux (arch needs to be calledarm
as well).Ok this drove me nuts, but I think I've got it working now: https://github.com/carapace-sh/carapace-bin/releases/tag/v1.0.3
First of all most of the
android
targets needCGO_ENABLED=1
.Then there's the need for a patched runtime due to the
/data/data/com.termux/files
prefix (adopted from the golang package).Two builds so that for termux the patched
gobinary
can be used. Then add atermux
suffix to the archives for clarity.CC
environment variable set. I used a script for this (/usr/local/bin/go-termux
).gh_pages
. Just needs a fix as goreleaser usesdata.tar.gz
.related #3333
related #4812
related termux/termux-apt-repo#25