Feature/update management server #1022
Open
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swermin
requested review from
markmandel,
XAMPPRocky,
koslib and
Jake-Shadle
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
XAMPPRocky
reviewed
Sep 27, 2024
|
I am currently working on signing the cla, but its gonna take a while since I am doing it on the behalf of the company |
markmandel
reviewed
Sep 27, 2024
| @@ -44,6 +44,13 @@ pub struct Manage { | |||
| /// The configuration source for a management server. | |||
| #[clap(subcommand)] | |||
| pub provider: crate::config::Providers, | |||
| /// If specified, filters the available gameserver addresses to the one that | |||
| /// matches the specified type | |||
There was a problem hiding this comment.
Just noting that this will update the docs as well, since they are autogenerated - so no need for changes there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This PR extends the
management serverto also support filtering address types for game servers the same way theagentis doing