Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support urllib3 >= 2.0.0 #1290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions google/auth/transport/urllib3.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ class Request(transport.Request):
credentials.refresh(request)

Args:
http (urllib3.request.RequestMethods): An instance of any urllib3
class that implements :class:`~urllib3.request.RequestMethods`,
http (urllib3._request_methods.RequestMethods): An instance of any urllib3
class that implements :class:`~urllib3._request_methods.RequestMethods`,
usually :class:`urllib3.PoolManager`.

.. automethod:: __call__
Expand Down Expand Up @@ -192,8 +192,9 @@ class AuthorizedHttp(urllib3._request_methods.RequestMethods): # type: ignore
response = authed_http.request(
'GET', 'https://www.googleapis.com/storage/v1/b')

This class implements :class:`urllib3.request.RequestMethods` and can be
used just like any other :class:`urllib3.PoolManager`.
This class implements
:class:`urllib3._request_methods.RequestMethods` and can be used
just like any other :class:`urllib3.PoolManager`.

The underlying :meth:`urlopen` implementation handles adding the
credentials' headers to the request and refreshing credentials as needed.
Expand Down