hal/gles: support externally initialized contexts #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have the same error as in #2297 , so problem is not related to winit. bug.mp4 |
|
glutin does not support wasm taget (rust-windowing/glutin#1167), so for wasm need to create separate example in future. |
The examples in wgpu-hal aren't handling window resize, and it's not their goal to do so. This is irrelevant of the PR here.
we could put stuff in the same example, just not using glutin, via a bunch of |
cwfitzgerald
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #2344
cc @lpenguin @caiiiycuk
Description
This PR attempts to make minimal set of changes to be able to use GLES in a context we aren't creating.
Overall, I'm happy with the way it turned out, especially
struct EglContextpart.Testing
Comes with a whole example!