Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: spacing issues #179

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix: spacing issues #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
361fbb4
#170 Data Sources template page spacing fix
tmark-work Jan 23, 2019
0035cf7
#171 Fix knowledge base spacing
tmark-work Jan 23, 2019
527694c
#171 additional style fix
tmark-work Jan 23, 2019
4c4b636
#171 Correct spacing fix for KB homepage
tmark-work Jan 23, 2019
ee15c48
Merge branch 'spacing_issues' of github.com:getredash/website into sp…
tmark-work Jan 23, 2019
6becb8a
#171 fix wrong merge issue
tmark-work Jan 23, 2019
c997920
#174 fix homepage spacing
tmark-work Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 19 additions & 21 deletions src/pages/help/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,28 +74,26 @@ class HelpPage extends React.Component {
{this.state.searchQuery.length === 0 && (
<div className="container content">
{Sections.edges.map(({ node }) => (
<div key={node.id}>
<div className="topics topics--mb-xl" key={node.id}>
<h3>{node.name}</h3>
<div className="topics topics--mb-xl">
<div className="row row--flex">
{Categories.edges
.filter(
({ node: { frontmatter } }) =>
frontmatter.parent_category === node.slug
)
.map(({ node: { frontmatter } }) => (
<div className="col-sm-4" key={frontmatter.title}>
<Link
to={`/help/${frontmatter.parent_category}/${
frontmatter.category
}`}
className="topics__item"
>
{frontmatter.title}
</Link>
</div>
))}
</div>
<div className="row row--flex">
{Categories.edges
.filter(
({ node: { frontmatter } }) =>
frontmatter.parent_category === node.slug
)
.map(({ node: { frontmatter } }) => (
<div className="col-sm-4" key={frontmatter.title}>
<Link
to={`/help/${frontmatter.parent_category}/${
frontmatter.category
}`}
className="topics__item"
>
{frontmatter.title}
</Link>
</div>
))}
</div>
</div>
))}
Expand Down
2 changes: 1 addition & 1 deletion src/scss/_components/_section.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
}

.section--hero {
padding: 25px 0 125px;
padding: 25px 0 80px;
overflow: hidden;

h1 {
Expand Down
4 changes: 2 additions & 2 deletions src/templates/DataSourcePage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default function DataSourcePageTemplate({
/>
<p className="from-to-holder__title">{frontmatter.name}</p>
</div>
<div className="from-to-plus"> + </div>
<div className="from-to-plus">&nbsp;+&nbsp;</div>
<div className="from-to-holder__item">
<img
src="/assets/images/redash-256.png"
Expand Down Expand Up @@ -94,6 +94,7 @@ export default function DataSourcePageTemplate({
</li>
<li>
<b>Supported visualizations</b>:
<br />
<span className="label label-primary">
Charts: Line, Bar, Area, Pie, Scatter
</span>
Expand Down Expand Up @@ -122,7 +123,6 @@ export default function DataSourcePageTemplate({
className="img-responsive center-block img-rounded img--has-shadow"
alt="Slack chat demo"
/>
>
</div>

<div className="col-md-6">
Expand Down