Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add priorityClassName to server, worker, scheduler and migration pods #185

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add priorityClassName to server, worker, scheduler and migration pods #185

merged 1 commit into from
Aug 5, 2024

Conversation

sabyrzhan
Copy link
Contributor

Add priorityClassName to server, worker, scheduler and migration pods to assign custom priority values

@sabyrzhan
Copy link
Contributor Author

@frivoire hey, is there any way to review and merge this PR?

frivoire
frivoire approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@frivoire frivoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review (I didn't test it): it looks nice and clean 👍

@frivoire
Copy link
Contributor

frivoire commented Aug 2, 2024

@frivoire hey, is there any way to review and merge this PR?

I've reviewed it, but I'm not a maintainer of this repo, just a contributor (who got a PR merged in the paste).
So I can't help you more here, sorry.

@sabyrzhan
Copy link
Contributor Author

@frivoire Thanks a lot for your review and approve. Could you mention somebody you know who have right to merge?

@justinclift
Copy link
Member

@frivoire If you're interested (?) I'm happy to give you maintainer access to this repo. 😄

@sabyrzhan
Copy link
Contributor Author

@justinclift could you please merge my PR since now it is approved?

@justinclift justinclift merged commit 49dfc0b into getredash:master Aug 5, 2024
7 checks passed
@justinclift
Copy link
Member

Done. 😄

@sabyrzhan
Copy link
Contributor Author

@justinclift Thanks a lot for merging. But i see publishing failed: https://github.com/getredash/contrib-helm-chart/actions/runs/10248352351/job/28349786442. Looks like same tag already published before me.

@sabyrzhan
Copy link
Contributor Author

@justinclift I bumped the version here and created new PR: #186. Please look

@justinclift
Copy link
Member

Done. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frivoire frivoire frivoire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabyrzhan @frivoire @justinclift