Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set margin fields for purchase documents when updating items (backport #43475) #43485

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: set margin fields for purchase documents when updating items (backport #43475) #43485

merged 1 commit into from
Oct 2, 2024
+9 −14

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 2, 2024

Issue

Rate changes on save because both discount and margin are set.

Solution

revert: 81c2175
margin fields introduced in: #24685

This is an automatic backport of pull request #43475 done by Mergify.

@mergify mergify bot requested a review from deepeshgarg007 as a code owner October 2, 2024 09:52
@sagarvora sagarvora merged commit 661eb05 into version-15-hotfix Oct 2, 2024
12 checks passed
@sagarvora sagarvora deleted the mergify/bp/version-15-hotfix/pr-43475 branch October 2, 2024 09:54
@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees

@sagarvora sagarvora

Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sagarvora