fix: Get Entries not showing accounts with no gain or loss in Exchange Rate Revaluation issue fixed #43414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishakhdesai
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
…e Rate Revaluation issue
vishakhdesai
force-pushed
the
exchange-rate-revaluation-issue
branch
from
6cc303c
to
6de6f55
Compare
sagarvora
added
backport version-14-hotfix
sagarvora
added
the
squash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Get Entriesin Exchange Rate Revaluation is not fetching those entries where gain/loss is zero. User may want to set a different exchange rate manually.Fix:
Remove the condition
if_gain_lossfromcalculate_new_account_balancemethod and instead remove the rows with zero gain/loss inbefore_submit.