Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring: Use tryJust instead of pattern guards #71

Closed
wants to merge 4 commits into from

Conversation

sol
Copy link
Contributor

@sol sol commented May 22, 2023

Doing this first will give us a smaller diff for #70, hopefully putting us into a better position to make progress there.

This reduces the diff for #70 to essentially: sol@4c5d917

But ignoring #70 for a moment, I still think this is a reasonable improvement.

@tomjaguarpaw
Copy link
Collaborator

I found this a little hard to follow. Could you please rebase on https://github.com/tomjaguarpaw/typed-process/tree/terminateProcess for clarity? That makes each of the steps painfully obvious.

@sol
Copy link
Contributor Author

sol commented May 22, 2023

I found this a little hard to follow. Could you please rebase on https://github.com/tomjaguarpaw/typed-process/tree/terminateProcess for clarity? That makes each of the steps painfully obvious.

done.

@tomjaguarpaw
Copy link
Collaborator

If find the tryJust and guard much harder to understand, actually, but I think my three commits are equally good for your purpose, @sol, are they not? Unless they're not, I intend to merge them in #72.

@sol
Copy link
Contributor Author

sol commented May 23, 2023

Anything works for me. Closing in favor of #72.

@sol sol closed this May 23, 2023
@sol sol deleted the refactor branch May 23, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants