Make left side bar move in/out #150 #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request implements the functionality to make the left sidebar move in and out based on user interaction and screen size. The changes involve updating the Vue components and styles to handle the sidebar's visibility and positioning dynamically. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @odkhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider reducing code duplication in CSS changes across multiple files. A global CSS class or mixin could be used to handle layout adjustments when the sidebar is closed.
- Review the changes to sidebar behavior, especially in relation to route changes. Ensure that the sidebar state is managed correctly across different scenarios.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
Please add screenshots. |
|
The goal of this issue is to regain the feature of the last eventyay version. There should be an icon to move the top bar in and out. This PR creates a top bar which is not desired. Compare:
|
|
Given the existing design it seems like the functionality of a "Sidenav push (off-canvas)" would be suitable. Compare here: https://www.w3schools.com/howto/howto_js_sidenav.asp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
This pull request adds the ability to toggle the visibility of the left sidebar. It includes updates to multiple components and views to ensure the layout adjusts correctly when the sidebar is shown or hidden.