Add talk-component to dashboard #272

AviGawande · 2024-08-01T18:07:56Z

This PR fixes #257
Attached Screenshot

Summary by Sourcery

Add a new 'Components' page to the dashboard to check the installation status of 'eventyay-talk'. Revamp the layout and styling of the authentication base template and update the index page with additional information and resources.

New Features:

Introduce a new 'Components' page in the dashboard to check the installation status of 'eventyay-talk' and provide a link to it if installed.

Enhancements:

Revamp the layout and styling of the authentication base template to include a new navigation bar and sidebar.
Update the index page to include additional information and resources for users.

Co-authored-by: Mario Behling <[email protected]>

* Update Stripe to more recent version

* upgrade vue version from 2.6.12 -> 2.7.14 * load vue.min.js file for prod env and vue.js for debug purposes * set default value to empty string in select field --------- Co-authored-by: Mario Behling <[email protected]>

* pump python to version 3.11 * Update pyproject.toml with correct Django version --------- Co-authored-by: Mario Behling <[email protected]> Co-authored-by: Norbert Preining <[email protected]>

* Update Stripe to more recent version

* Fix Badge API documentation error * Added Default Values for Size

* Update Stripe to more recent version

* upgrade vue version from 2.6.12 -> 2.7.14 * load vue.min.js file for prod env and vue.js for debug purposes * set default value to empty string in select field --------- Co-authored-by: Mario Behling <[email protected]>

* pump python to version 3.11 * Update pyproject.toml with correct Django version --------- Co-authored-by: Mario Behling <[email protected]> Co-authored-by: Norbert Preining <[email protected]>

* Update Stripe to more recent version

* Fix Badge API documentation error * Added Default Values for Size

* correct path for stripe plugin template

Update master with latest development changes.

* update text + fields position * added global setting for email, update function get_mail_backend * added text field for ticket question form * align left for text field

* add support Ukrainan * change Ukrainian langcode from uk-UA to uk * update css to show ukraina flag

Updating master with latest development changes.

* set required to False for question with type is DES, remove question with type DES out of cart

* remove support for Mariadb/MySQL

* Improve flow for required field of Yes-No question

Co-authored-by: Mario Behling <[email protected]>

* Add plugins to autodeployment with docker

* Implement option to add link to privacy policy

* add footer link for event + organizer

* Replace pkg_resources with import importlib_metadata

* Do not repeat questions in form field of ticket form

* implement customer feature * implement customer SSO provider & client * add docs for customer functions

* fix error when create an event from another event

* integrate with SendGrid * add dependency for sendgrid * revert gitignore * added global setting for email, update function get_mail_backend * load default setting from .cfg file

* Use master branch in docker-pr workflow * Update workflow test postgres version to 12

sourcery-ai · 2024-08-01T18:08:04Z

Reviewer's Guide by Sourcery

This pull request introduces a new talk-component to the dashboard by updating the layout and styling of the authentication and presale pages, adding new sections for better user experience, and implementing a new ComponentsView with a corresponding URL pattern and template to display the components page.

File-Level Changes

Files	Changes
`src/pretix/control/templates/pretixcontrol/auth/base.html` `src/pretix/presale/templates/pretixpresale/index.html` `src/pretix/static/pretixcontrol/scss/auth.scss`	Updated the layout and styling of the authentication and presale pages, including new sections and improved responsiveness.
`src/pretix/control/views/auth.py` `src/pretix/control/urls.py` `src/pretix/control/templates/pretixcontrol/auth/components.html`	Added a new ComponentsView and corresponding URL pattern and template to display the components page.

Tips

Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
Continue your discussion with Sourcery by replying directly to review comments.
You can change your review settings at any time by accessing your dashboard:
- Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
- Change the review language;
You can always contact us if you have any questions or feedback.

sourcery-ai

Hey @AviGawande - I've reviewed your changes - here's some feedback:

Overall Comments:

The ComponentsView function in auth.py uses a hardcoded file path. This should be replaced with a configurable setting to ensure the code works across different environments.
The addition of ComponentsView in auth.py seems to mix concerns. Consider moving this functionality to a more appropriate location in the codebase.

Here's what I looked at during the review

🟡 General issues: 1 issue found
🟡 Security: 1 issue found
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

sourcery-ai · 2024-08-01T18:09:34Z

src/pretix/control/views/auth.py

@@ -439,3 +439,17 @@ def get_context_data(self, **kwargs):

    def get(self, request, *args, **kwargs):
        return super().get(request, *args, **kwargs)
+
+
+def ComponentsView(request):


🚨 suggestion (security): Consider using a configuration variable for the parent directory path

The hardcoded path '/home/abhigawande/Downloads/fossasia' is not portable and could lead to security issues. Consider using a configuration variable or environment variable for this path.

def ComponentsView(request): parent_directory = settings.FOSSASIA_DIRECTORY

sourcery-ai · 2024-08-01T18:09:34Z

src/pretix/presale/templates/pretixpresale/index.html

+                {% endblocktrans %}
+            </p>
+            <p>
+                {% trans "This is a self-hosted installation of" %}


suggestion: Optimize repeated translated strings

There's repetition of translated strings. Consider using a single translated string for repeated content to improve maintainability.

Suggested change

{% trans "This is a self-hosted installation of" %}

{% blocktrans trimmed %}

This is a self-hosted installation of <a href="https://eventyay.com">eventyay, your open source event solution</a>.

{% endblocktrans %}

hongquan · 2024-08-02T02:14:09Z

src/pretix/control/templates/pretixcontrol/auth/components.html

+
+            {% if is_eventyay_talk_installed %}
+                <p>
+                    <a href="http://127.0.0.1:8000/eventyay-talk" class="btn btn-primary">


Why is the hostname hardcoded as "127.0.0.1:8000"? It will not work in live system.

had put this while testing,i had corrected it now.

hongquan · 2024-08-02T02:14:34Z

src/pretix/control/urls.py

@@ -16,6 +16,7 @@
    url(r'^invite/(?P<token>[a-zA-Z0-9]+)$', auth.invite, name='auth.invite'),
    url(r'^forgot$', auth.Forgot.as_view(), name='auth.forgot'),
    url(r'^forgot/recover$', auth.Recover.as_view(), name='auth.forgot.recover'),
+    url(r'^component$',auth.ComponentsView, name='auth.component'),


There should be a whitespace after ,.

hongquan · 2024-08-02T02:15:24Z

src/pretix/control/views/auth.py

+        'eventyay_talk_path': eventyay_talk_path if is_eventyay_talk_installed else None,
+    }
+
+    return render(request, 'pretixcontrol/auth/components.html', context)


Add one blank line at the end of file and configure your IDE to automatically do so,

hongquan · 2024-08-02T02:20:02Z

src/pretix/presale/templates/pretixpresale/index.html

+            <h2>{% trans "WELCOME TO EVENTYAY-TICKETS" %}</h2>
+            <p>
+                {% blocktrans trimmed with a_attr="href='https://eventyay.com'" %}
+                    This is a self-hosted installation of <a {{ a_attr }}>eventyay, your open source event solution.</a>.


It is a bad practice to put code (like <a>, </a>) in to-be-translated string. Because those strings will be handovered to translators, who are not tech persons and will likely put wrong code, which will break our site when the translated strings are applied.

But this mistake is from the original pretalx code. It is not urgent to fix right now.

odkhang and others added 30 commits June 19, 2024 21:14

Replace deprecated PdfMerger with PdfWriter (#173)

fb7bfb6

Co-authored-by: Mario Behling <[email protected]>

Update Stripe to more recent version (#167)

ef7b99c

* Update Stripe to more recent version

Upgrade to recent 2.x VueJS (#177)

8c8416a

* upgrade vue version from 2.6.12 -> 2.7.14 * load vue.min.js file for prod env and vue.js for debug purposes * set default value to empty string in select field --------- Co-authored-by: Mario Behling <[email protected]>

Upgrade to Python 3.11 (#184)

0d68953

* pump python to version 3.11 * Update pyproject.toml with correct Django version --------- Co-authored-by: Mario Behling <[email protected]> Co-authored-by: Norbert Preining <[email protected]>

optimize package import for stripe update (#198)

4d82a91

* Update Stripe to more recent version

Add orientation and height fields to Badgelayouts API response (#197)

7ecacaa

* Fix Badge API documentation error * Added Default Values for Size

Merge branch 'master' into development

100fd79

Update Stripe to more recent version (#167)

e27f132

* Update Stripe to more recent version

Upgrade to recent 2.x VueJS (#177)

ebf5c37

* upgrade vue version from 2.6.12 -> 2.7.14 * load vue.min.js file for prod env and vue.js for debug purposes * set default value to empty string in select field --------- Co-authored-by: Mario Behling <[email protected]>

Upgrade to Python 3.11 (#184)

703314a

* pump python to version 3.11 * Update pyproject.toml with correct Django version --------- Co-authored-by: Mario Behling <[email protected]> Co-authored-by: Norbert Preining <[email protected]>

optimize package import for stripe update (#198)

f370c39

* Update Stripe to more recent version

Add orientation and height fields to Badgelayouts API response (#197)

201784c

* Fix Badge API documentation error * Added Default Values for Size

Merge branch 'master' into development

146cf9c

Stripe plugin - correct template path (#201)

fea6b17

* correct path for stripe plugin template

Fix stripe incorrect gettext, update messages etc (#202)

f98b9e0

add support Ukrainan (#210)

569c78b

support html / markdown for question title (#211)

abbde0c

Merge pull request #212 from fossasia/development

c79035e

Update master with latest development changes.

Add text field as an option into the question page (#209)

fab0799

* update text + fields position * added global setting for email, update function get_mail_backend * added text field for ticket question form * align left for text field

Hot fix Ukrainian language (#214)

8a21ac5

* add support Ukrainan * change Ukrainian langcode from uk-UA to uk * update css to show ukraina flag

Merge pull request #216 from fossasia/development

f34d767

Updating master with latest development changes.

Hot fix Feature 171 (#218)

b626911

* set required to False for question with type is DES, remove question with type DES out of cart

Remove mariadb support (#183)

a292acb

* remove support for Mariadb/MySQL

Improve flow for required field of Yes-No question (#206)

19640c4

* Improve flow for required field of Yes-No question

Dynamic updation of Badge Size (#221)

326c3c2

Co-authored-by: Mario Behling <[email protected]>

Add plugins to autodeployment with docker (#208)

e3480f8

* Add plugins to autodeployment with docker

Implement option to add link to privacy policy (#227)

f6d88ff

* Implement option to add link to privacy policy

Option to add customizable links to footer (#225)

7568897

* add footer link for event + organizer

Replace pkg_resources (#232)

052fa20

* Replace pkg_resources with import importlib_metadata

Do not repeat questions in form field of ticket form (#235)

4ecc8f0

* Do not repeat questions in form field of ticket form

Sak1012 and others added 14 commits July 13, 2024 15:16

Added templates (#229)

5b5b64b

Merge branch 'development'

4f81a16

Implement customer accounts in system (#223)

93068bc

* implement customer feature * implement customer SSO provider & client * add docs for customer functions

Fix issue when create an event from other event configuration (#239)

fd9c2fd

* fix error when create an event from another event

change default color for new organization (#240)

048a39d

Implement Support for Sendgrid on a System and User Level (#195)

4d0b066

* integrate with SendGrid * add dependency for sendgrid * revert gitignore * added global setting for email, update function get_mail_backend * load default setting from .cfg file

Use master branch in docker-pr workflow (#243)

3558a8b

* Use master branch in docker-pr workflow * Update workflow test postgres version to 12

fix issue when send mail to invite member (#244)

e25a6e8

Allows tab IDs to be set in the HTML code (#247)

63d245d

skip check for empty country (#246)

dcfd7a6

Revoked devices to be removed from device list (#249)

12092bf

implement-dashboard-layout

3364213

append-wrapper-styling

25f877f

implement-talk-component

4e02d86

sourcery-ai bot reviewed Aug 1, 2024

View reviewed changes

hongquan requested changes Aug 2, 2024

View reviewed changes

AviGawande added 2 commits August 2, 2024 12:29

fix-redirect-url

d3ce0a3

update-components-template

380120f

odkhang force-pushed the development branch 2 times, most recently from d832dd9 to 80c867c Compare August 15, 2024 09:34

AviGawande closed this by deleting the head repository Aug 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add talk-component to dashboard #272

Add talk-component to dashboard #272

AviGawande commented Aug 1, 2024 •

edited

Loading

sourcery-ai bot commented Aug 1, 2024 •

edited

Loading

sourcery-ai bot left a comment

sourcery-ai bot Aug 1, 2024

sourcery-ai bot Aug 1, 2024

hongquan Aug 2, 2024

AviGawande Aug 2, 2024

hongquan Aug 2, 2024

hongquan Aug 2, 2024

hongquan Aug 2, 2024

Add talk-component to dashboard #272

Add talk-component to dashboard #272

Conversation

AviGawande commented Aug 1, 2024 • edited Loading

Summary by Sourcery

sourcery-ai bot commented Aug 1, 2024 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

sourcery-ai bot left a comment

Choose a reason for hiding this comment

sourcery-ai bot Aug 1, 2024

Choose a reason for hiding this comment

sourcery-ai bot Aug 1, 2024

Choose a reason for hiding this comment

hongquan Aug 2, 2024

Choose a reason for hiding this comment

AviGawande Aug 2, 2024

Choose a reason for hiding this comment

hongquan Aug 2, 2024

Choose a reason for hiding this comment

hongquan Aug 2, 2024

Choose a reason for hiding this comment

hongquan Aug 2, 2024

Choose a reason for hiding this comment

AviGawande commented Aug 1, 2024 •

edited

Loading

sourcery-ai bot commented Aug 1, 2024 •

edited

Loading