Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Remove sys_ptrace dependency #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pingsutw
Copy link
Member

Signed-off-by: Kevin Su [email protected]

TL;DR

Remove shared process watcher, and use file watcher by default.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Stop exitWatcher if an empty file named SUCCESS isn't present after some amount of time.

Tracking Issue

flyteorg/flyte#2162

Follow-up issue

NA

@welcome
Copy link

welcome bot commented Mar 14, 2022

Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line: - Most of the repos have a PR template; if not, fill it out to the best of your knowledge. - Sign off your commits (Reference: DCO Guide).

@pingsutw pingsutw changed the title [WIP] Remove sys_ptrace dependency Remove sys_ptrace dependency Mar 15, 2022
Signed-off-by: Kevin Su <[email protected]>
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #36 (f691b3b) into master (b1ba2f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   17.79%   17.79%           
=======================================
  Files           3        3           
  Lines         399      399           
=======================================
  Hits           71       71           
  Misses        315      315           
  Partials       13       13           
Flag Coverage Δ
unittests 16.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ba2f7...f691b3b. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant