Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Partial revert PR #853 #865

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Apr 19, 2024

TL;DR

#853 breaks the production environment. This PR partially revert it by making LOCAL_DEV_HOST to read from the environment variable instead of a hard-coded value.

Related PR: #864

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Tracking Issue

N/A

Follow-up issue

NA

@MortalHappiness MortalHappiness changed the title fix: Partial revert flyteorg/flyteconsole#853 fix: Partial revert PR #853 Apr 19, 2024
@jsonporter jsonporter merged commit 7bf5a25 into flyteorg:master Apr 19, 2024
3 checks passed
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants