feat(fluentd): add image reference by digest #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael McLeroy <[email protected]>
Signed-off-by: Michael McLeroy <[email protected]>
Signed-off-by: Michael McLeroy <[email protected]>
Boojapho
force-pushed
the
image-digest-fluentd
branch
from
ece9c3b
to
ca82496
Compare
dioguerra
requested changes
Nov 15, 2023
| @@ -10,7 +10,16 @@ kind: "DaemonSet" | |||
| image: | |||
| repository: "fluent/fluentd-kubernetes-daemonset" | |||
| pullPolicy: "IfNotPresent" | |||
| tag: "" | |||
| tag: "" # Set to "-" to not use the default value | |||
There was a problem hiding this comment.
Sorry, I just tested and everything works fine.
Just drop the comment in front of tag which is not required...
helm template fluentd . -n kube-system -s templates/daemonset.yaml --set image.repository=myrepo/myimage --set image.tag=1.1.1 --set image.digest=sha256:4a1c4b21597c1b4415bdbecb28a3296c6b5e23ca4f9feeb599860a1dac6a0108
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: fluentd | |||
| description: A Helm chart for Kubernetes | |||
| # type: application | |||
| version: 0.4.3 | |||
| version: 0.4.4 | |||
dioguerra
requested changes
Nov 15, 2023
| Fluentd image with tag/digest | ||
| */}} | ||
| {{- define "fluentd.image" -}} | ||
| {{- $tag := ternary "" (printf ":%s" (toString .tag)) (or (empty .tag) (eq "-" (toString .tag))) -}} |
There was a problem hiding this comment.
tags and hashes can coexist, where hash will always takes precedence over the tag, even if they dont match.
With this info you should be able to simplify this. Although it works as it is...
|
Thank you for your contribution @Boojapho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #356
Adds ability to reference images by digest. Digest will override tag.
Also fixed fluentd test.
Closes: #440