Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: make it compile with DISABLE_UPDATE_CHECKER #3294

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Fix: make it compile with DISABLE_UPDATE_CHECKER #3294

merged 1 commit into from
Aug 20, 2023

Conversation

iacore
Copy link
Contributor

@iacore iacore commented Aug 6, 2023

No description provided.

@mmahmoudian
Copy link
Member

mmahmoudian commented Aug 7, 2023 •
edited
Loading

Thanks for the PR, but does this fix an existing issue?

@iacore
Copy link
Contributor Author

iacore commented Aug 7, 2023 •
edited
Loading

Thanks for the PR, but does this fix an existing issue?

Before this patch, if you try to compile the project -DDISABLE_UPDATE_CHECKER=1, it doesn't work (compile error).

@veracioux
Copy link
Contributor

This looks good, going to merge it after our CI/CD is fixed.

@veracioux veracioux merged commit dff3fe8 into flameshot-org:master Aug 20, 2023
12 of 22 checks passed
panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request Dec 22, 2023
@iacore
Fix: make it compile with DISABLE_UPDATE_CHECKER (flameshot-org#3294)
66ab3a5 
(cherry picked from commit dff3fe8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veracioux veracioux veracioux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iacore @mmahmoudian @veracioux