Add gnome-based wayland universal screenshot adapter #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack9603301
force-pushed
the
master
branch
3 times, most recently
from
7af9344
to
7a23521
Compare
By default, flameshot uses the program's default dbus protocol interface to communicate with gnome's screenshot protocol, but this is now broken on some gnome installations, so we'll use gnome-screenshot as gnome's wayland screenshot adapter and then communicate directly with the gnome screenshot component! To enable the GNOME-based generic wayland screenshot adapter, enable it using the following cmake parameter: ``` -DUSE_WAYLAND_GNOME=true ```
|
@mmahmoudian This solution is pending review, and it seems to work fine in GNOME |
|
@jack9603301 thanks for the fix! I have tested this on my setup and after installing gnome-screenshot (is this a legacy package? It looks like an old-version of the already build-in screenshot tool) flameshot finally works again. I'm on Ubuntu 23.10 6.5.0-21 wayland. However I noticed a performance issue, I'm running two 4k screens and when selecting the area to screenshot it lags terribly. Feels like 2 FPS. But at least it works 👍 |
|
Great work, this finally makes flameshot work under arch/gnome/wayland! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, flameshot uses the program's default dbus protocol interface to communicate with gnome's screenshot protocol, but this is now broken on some gnome installations, so we'll use gnome-screenshot as gnome's wayland screenshot adapter and then communicate directly with the gnome screenshot component!
Designed to address: #3213