Copy path to clipboard using native separators #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petru Gurduza <[email protected]>
|
Thanks, looks good to me. I still rather another dev review it, but I add it to next release milestone. |
|
It looks good, make it run without issues (clang-format) and we can merge it. |
Signed-off-by: Petru Gurduza <[email protected]>
veracioux
requested changes
Aug 20, 2023
|
@petrucianno Thanks for the change. Did you run clang-format again? The clang-format Github action is failing. |
petrugrd
force-pushed
the
issue-3135-fix
branch
from
475373b
to
2328ffd
Compare
Signed-off-by: Petru Gurduza <[email protected]>
petrugrd
force-pushed
the
issue-3135-fix
branch
from
2328ffd
to
79f818e
Compare
panpuchkov
pushed a commit
to namecheap/flameshot
that referenced
this pull request
Dec 22, 2023
* Copy path to clipboard using native separators Signed-off-by: Petru Gurduza <[email protected]> * Copy path to clipboard using native separators Signed-off-by: Petru Gurduza <[email protected]> * Use native separators in save path Signed-off-by: Petru Gurduza <[email protected]> --------- Signed-off-by: Petru Gurduza <[email protected]> (cherry picked from commit 05226bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #3135