fix bug of extended_preview_controller #1280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
こちらもこの修正で良いと思います． |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
euslisp/jskeus#551
extended-preview-cotrollerクラスの計算過程に誤りがあったため、修正しました。
Qの値が1.0で無いとき、正しい出力を返しません。
このPull Requestによる修正前後での
testPreviewControllerの出力を添付いたします。Q,Rの値を両方とも1e3倍したときに、理論上は出力は変わらないはずであるにも関わらず、修正前では出力が大きく変わっています。
現状(修正前)
Q=1, R=1e-6の場合。問題なし。
Q=1e3, R=1e-3の場合。正しく機能しない。
本PullRequest適用後
Q=1, R=1e-6の場合。本Pull Request適用前と変化なし。
Q=1e3, R=1e-3の場合。正しく機能する。
