-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ReadME. Fix case for extension dependency #7764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to approve this PR but I forgot if it's approve, Approve or aPProVe, sorry!
@@ -14,7 +14,7 @@ | |||
"Other" | |||
], | |||
"extensionDependencies": [ | |||
"graphql.vscode-graphql-syntax" | |||
"GraphQL.vscode-graphql-syntax" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you copy the extension id from the 3dot menu it's capitalized in both VSCode and open-vsx. This fix is targeted at fixing open-VSX builds. Locally it works fine and installs the dependency.
No description provided.