Skip to content

0.1.20221208-111736-r4b499bce

Pre-release
Pre-release
Compare
Choose a tag to compare
@github-actions github-actions released this 08 Dec 19:51
· 13693 commits to main since this release
service: only allow takeover if all mounts are initialized

Summary:
The most common crash on macOS is when a graceful restart is performed while a
mount is ongoing. In this case, an EDEN_BUG is raised in EdenFS leading to
EdenFS to crash and restart.

As a very easy solution, let's check prior to starting graceful restart if
there are any ongoing mounts, and if so, just abort the graceful restart. Note
that there is still a potential race if a mount occurs right after this check,
but that should be significantly more rare and unlikely to happen in practice.

Reviewed By: kmancini

Differential Revision: D41640271

fbshipit-source-id: c0fd0cc0305cbcdd941aa0e2e422706af799d5b3