Add json content handler for /forks #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pk910
reviewed
Sep 29, 2024
| @@ -31,6 +33,21 @@ func Forks(w http.ResponseWriter, r *http.Request) { | |||
| handlePageError(w, r, pageError) | |||
| return | |||
| } | |||
|
|
|||
| if r.Header.Get("Content-Type") == "application/json" { | |||
There was a problem hiding this comment.
Should check for the Accept header here.
Content-Type in requests describes the type of the data being delivered with the request.
Its used for POST/PUT/PATCH requests only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using Dora for some testing and really like exposing the /forks page to allow dumping the forks as JSON. I would be eager to have this merged. Do you have any recommendations?