new(tests): EIP-2935 - Update tests to recent spec change #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
force-pushed
the
tests/prague/eip2935/spec-change-updates-1
branch
2 times, most recently
from
5a1ae88
to
3888c93
Compare
marioevz
reviewed
Jun 4, 2024
tests/prague/eip2935_historical_block_hashes_from_state/test_block_hashes.py
Outdated
Show resolved
Hide resolved
tests/prague/eip2935_historical_block_hashes_from_state/test_block_hashes.py
Outdated
Show resolved
Hide resolved
tests/prague/eip2935_historical_block_hashes_from_state/test_block_hashes.py
Outdated
Show resolved
Hide resolved
marioevz
force-pushed
the
tests/prague/eip2935/spec-change-updates-1
branch
from
3888c93
to
f524a05
Compare
marioevz
changed the title
marioevz
approved these changes
Jun 25, 2024
marioevz
changed the title
spencer-tb
added a commit
that referenced
this pull request
Jun 26, 2024
* chore(fw): create contracts folder for bin files. * feat(fw): remove history storage contract. * feat(tests): update eip2935 transtion tests to new spec. * typo * fix(forks): History contract * fix(tests): nits * fix(tests): HISTORY_STORAGE_ADDRESS spec update * fix(tests): refactor transition tests, helper function, add post fork test * fix(tests): logic fixes * fix * fix: ref spec sha * feat(fw): Add `storage.canary()` * new(tests): add invalid block number requests * changelog --------- Co-authored-by: Mario Vega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Aims to update the existing EIP-2935 tests in conjuction with the recent spec change ethereum/EIPs#8577, removing the external contract and instead using a system contract.
The test cases now check for the following:
BLOCKHASHbehaves as it always has, can retrieve blockhashes. System contract cannot.BLOCKHASHbehaves as it always has, can retrieve blockhashes. System contract stores first blockhash during block processing, ready for retrival at the next block, nothing is retrievable yet.BLOCKHASHbehaves as it always has. System contract can incrementally retrieve all blockhash that have been stored within the contract.Remaining Todo's
ethereum/tests.🔗 Related Issues
#570
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.