Take make(1) executable name from $MAKE environment variable
#8888
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] A few places have the executable name hard-coded to `make`. However, the Makefiles require GNU make, which is might be available as another name. For instance, on *BSD where make(1) is another implementation, GNU make is available ase `gmake`. This was not a problem when building Erlang/OTP. But it was when running the tests. [How] The make variable `$(MAKE)` which always contain the name of (or path to) the make executable being used, is passed to the shell scripts. The shell scripts then use this variable, defaulting to `make` if necessary. In `lib/common_test/test_server/configure.ac`, the order in which the make executable is detected is swapped: `gmake` is tried first, then `make`.
CT Test Results 4 files 188 suites 2h 9m 52s ⏱️ Results for commit 1e40fa8. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
A few places have the executable name hard-coded to
make. However, the Makefiles require GNU make, which is might be available as another name. For instance, on *BSD where make(1) is another implementation, GNU make is available asegmake.This was not a problem when building Erlang/OTP. But it was when running the tests.
How
The make variable
$(MAKE)which always contain the name of (or path to) the make executable being used, is passed to the shell scripts. The shell scripts then use this variable, defaulting tomakeif necessary.In
lib/common_test/test_server/configure.ac, the order in which the make executable is detected is swapped:gmakeis tried first, thenmake.