Fix SCTP fragment handling #8837
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaimoNiskanen
added
team:PS
CT Test Results 3 files 143 suites 46m 40s ⏱️ Results for commit 73e1aa1. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Getting ERRNO_BLOCK immediately could cause a buffer with message head to be wasted since it was forgotten that there was valid data in it.
Don't used the async return value functions except for TCP
that would block. All other cases are synchronous so return
the result (ok or {ok,AssocId}) directly from port control.
RaimoNiskanen
force-pushed
the
raimo/sctp/block-wastes-buffer/ERIERL-1133/OTP-19235
branch
from
73e1aa1
to
620fab3
Compare
|
Now rebased onto OTP-26.2.5, current OTP 26 patch base. |
RaimoNiskanen
force-pushed
the
raimo/sctp/block-wastes-buffer/ERIERL-1133/OTP-19235
branch
from
0427f24
to
ea4be99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting ERRNO_BLOCK immediately could cause a buffer with message head to be wasted since it was forgotten that there was valid data in it.