fix(solid): Run autoObserve Setup during Mounting Phase

See @ryansolid's comment in solidjs/solid#1936.
enthusiastic-js · Oct 30, 2023 · fdf61ed · fdf61ed
1 parent d55e90b
commit fdf61ed
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/solid/createFormValidityObserver.js b/packages/solid/createFormValidityObserver.js
@@ -1,5 +1,5 @@
 import FormValidityObserver, { defaultErrorRenderer } from "@form-observer/core/FormValidityObserver";
-import { onCleanup } from "solid-js";
+import { onMount, onCleanup } from "solid-js";
 
 /**
  * Creates an enhanced version of the {@link FormValidityObserver} that's more convenient for `Solid` apps
@@ -35,8 +35,8 @@ export default function createFormValidityObserver(types, options) {
   /* -------------------- Enhancements -------------------- */
   // Add automatic setup/teardown
   observer.autoObserve = function autoObserve(form, novalidate) {
-    observer.observe(form);
     if (novalidate()) form.setAttribute("novalidate", "");
+    onMount(() => observer.observe(form));
     onCleanup(() => observer.unobserve(form));
   };
 

diff --git a/packages/solid/package.json b/packages/solid/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@form-observer/solid",
   "type": "module",
-  "version": "0.0.0-experimental-4",
+  "version": "0.0.0-experimental-5",
   "description": "Convenience functions for the `@form-observer/core` package, designed for Solid apps",
   "exports": {
     ".": {