Distinguish b/w nonexistent and unreachable media #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMRobertson
force-pushed
the
dmr/return-codes
branch
from
2b27d9a
to
6e203a4
Compare
DMRobertson
force-pushed
the
dmr/return-codes
branch
from
6e203a4
to
4b1b30b
Compare
clokep
reviewed
Nov 27, 2023
| @@ -17,11 +17,14 @@ | |||
| class ErrCode(str, Enum): | |||
| # An unknown error happened. | |||
| UNKNOWN = "M_UNKNOWN" | |||
| # No route was found with the path and method provided in the request. | |||
| # One of the following: | |||
| # - No route was found with the path and method provided in the request. | |||
There was a problem hiding this comment.
FWIW This should return M_UNRECOGNISED for unknown paths/methods (see https://spec.matrix.org/v1.8/client-server-api/#common-error-codes).
reivilibre
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46.
I am assuming that after media retention kicks in, the remote homeserver responds to media requests with 404 M_NOT_FOUND. If so, the content scanner should do the same.
Mypy should pass once #53 lands.