Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint rules #1039

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Update eslint rules #1039

wants to merge 11 commits into from

Conversation

sleroq
Copy link

@sleroq sleroq commented Feb 18, 2023

I have noticed some inconsistencies in the code, which is why I am proposing an update to the ESLint configuration.

In this merge request, I removed .ts-eslintrc.js and added new rules to main eslint config.

I picked values are based on what gives fewer warnings and what we had in the past, so this may not be the best for each situation; however, this should provide a good starting point as far as making sure coding practices are consistent across all files.

That being said, I don't want to force anything upon anyone else working on this project - if you feel like some of these rules need changing or removing, then let's discuss it, so we can come up with something everyone agrees upon

I would appreciate any feedback before merging my request into master branch if possible!

@sleroq
Copy link
Author

sleroq commented Feb 18, 2023

I also suggest you to consider adding object-curly-spacing rule to the ESLint configuration,

I left it as it, because I'm not sure on the appropriate values for this rule.

@sleroq sleroq changed the title Eslint rules Update eslint rules Feb 18, 2023
Comment on lines +28 to +30
// "@typescript-eslint/no-misused-promises": "error",
// "@typescript-eslint/no-floating-promises": 2,
// "@typescript-eslint/explicit-function-return-type": "error"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than taking the to resolve the warnings, I opted to disable this rules for now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time

@KarriSauce
Copy link

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants