Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer option to hide media in the timeline. #3366

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 3, 2024

Adds an implementation for hiding media in the timeline (and notifications), accessed from the Developer options.

Still working on some snapshot tests, will include these before merging.

Closes #3228.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-03.at.14.36.31.mp4

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Oct 3, 2024
@pixlwave pixlwave requested a review from a team as a code owner October 3, 2024 13:37
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 3, 2024 13:37
Copy link

github-actions bot commented Oct 3, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against a143d31

@pixlwave pixlwave force-pushed the doug/hide-media-thumbnails branch 3 times, most recently from b6c6fa5 to dec8e4e Compare October 3, 2024 13:52
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice! 👏

Copy link

codecov bot commented Oct 3, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
839 2 837 0
View the top 1 failed tests by shortest run time
PreviewTests test_notificationSettingsScreen()
Stack Traces | 47s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_notificationSettingsScreen-iPhone-16-pseudo.1.png"
@+
"file:.../tmp/PreviewTests/test_notificationSettingsScreen-iPhone-16-pseudo.1.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.6503906 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
View the full list of 1 ❄️ flaky tests
PreviewTests test_loginScreen()

Flake rate in main: 35.59% (Passed 38 times, Failed 21 times)

Stack Traces | 6.41s run time
failed - Snapshot "matrix.org" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"
@+
"file:.../tmp/PreviewTests/test_loginScreen-iPhone-16-en-GB.matrix-org.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8511963 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link

sonarcloud bot commented Oct 3, 2024

@pixlwave pixlwave merged commit e6f4dd3 into develop Oct 3, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/hide-media-thumbnails branch October 3, 2024 16:59
@pixlwave pixlwave changed the title Initial implementation of hiding media in the timeline. Add developer option to hide media in the timeline. Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user controls for whether to display media (including thumbnails)
2 participants