Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use element-hq RTE version #3360

Merged
merged 2 commits into from
Oct 2, 2024
Merged

use element-hq RTE version #3360

merged 2 commits into from
Oct 2, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 2, 2024

And update its acknowledgements license.

@Velin92 Velin92 requested a review from a team as a code owner October 2, 2024 13:43
@Velin92 Velin92 requested review from stefanceriu and removed request for a team October 2, 2024 13:43
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

Copy link

github-actions bot commented Oct 2, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against f4f9f46

@Velin92 Velin92 added the pr-misc for other changes label Oct 2, 2024
@Velin92 Velin92 enabled auto-merge (squash) October 2, 2024 13:51
Copy link

sonarcloud bot commented Oct 2, 2024

@Velin92 Velin92 merged commit e0ee4be into develop Oct 2, 2024
7 checks passed
@Velin92 Velin92 deleted the mauroromito/update-rte branch October 2, 2024 14:30
Copy link

codecov bot commented Oct 2, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
838 1 837 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_loginScreen()

Flake rate in main: 39.13% (Passed 14 times, Failed 9 times)

Stack Traces | 2.23s run time
failed - Snapshot "matrix.org" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_loginScreen-iPhone-16-pseudo.matrix-org.png"
@+
"file:.../tmp/PreviewTests/test_loginScreen-iPhone-16-pseudo.matrix-org.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8482666 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants